-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Improve "update:check-requirements" command #1025
[CLI] Improve "update:check-requirements" command #1025
Conversation
Waiting for #1016 |
7b93bb2
to
c044299
Compare
c044299
to
6703cdb
Compare
6703cdb
to
48706eb
Compare
@@ -58,6 +59,8 @@ protected function configure(): void | |||
->setDescription('Check all prerequisites for an update.') | |||
->setHelp('This command allows you to check the prerequisites necessary for the proper functioning of an update.') | |||
->addOption('config-file-path', null, InputOption::VALUE_REQUIRED, 'Configuration file location for update.') | |||
->addOption('zip', null, InputOption::VALUE_REQUIRED, 'Sets the archive zip file for a local update.') | |||
->addOption('xml', null, InputOption::VALUE_REQUIRED, 'Sets the archive xml file for a local update.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
->addOption('xml', null, InputOption::VALUE_REQUIRED, 'Sets the archive xml file for a local update.') | |
->addOption('xml', null, InputOption::VALUE_REQUIRED, 'Sets the archive xml file for a local update.') |
48706eb
to
7505134
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @M0rgan01
Thank you for your PR, I tested it and it seems to works as you can see :
Tested from :
1.7.8.8 to 8.2
8.0.4 to 8.2
8.2 to 9.0.0
8.0.4 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
update:check-requirements
with new options