Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Improve "update:check-requirements" command #1025

Merged

Conversation

M0rgan01
Copy link
Contributor

Questions Answers
Description? Add "zip" and "xml" options for the command
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? -
Sponsor company -
How to test? Use update:check-requirements with new options

@M0rgan01 M0rgan01 added this to the 7.0.0 milestone Nov 20, 2024
@M0rgan01 M0rgan01 added the Blocked Status: The issue is blocked by another task label Nov 20, 2024
@M0rgan01
Copy link
Contributor Author

Waiting for #1016

@M0rgan01 M0rgan01 force-pushed the improve-check-requirements-command branch 3 times, most recently from 7b93bb2 to c044299 Compare November 20, 2024 14:49
@M0rgan01 M0rgan01 force-pushed the improve-check-requirements-command branch from c044299 to 6703cdb Compare November 25, 2024 11:04
@M0rgan01 M0rgan01 force-pushed the improve-check-requirements-command branch from 6703cdb to 48706eb Compare November 26, 2024 14:05
@M0rgan01 M0rgan01 removed the Blocked Status: The issue is blocked by another task label Nov 26, 2024
ga-devfront
ga-devfront previously approved these changes Nov 27, 2024
@@ -58,6 +59,8 @@ protected function configure(): void
->setDescription('Check all prerequisites for an update.')
->setHelp('This command allows you to check the prerequisites necessary for the proper functioning of an update.')
->addOption('config-file-path', null, InputOption::VALUE_REQUIRED, 'Configuration file location for update.')
->addOption('zip', null, InputOption::VALUE_REQUIRED, 'Sets the archive zip file for a local update.')
->addOption('xml', null, InputOption::VALUE_REQUIRED, 'Sets the archive xml file for a local update.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
->addOption('xml', null, InputOption::VALUE_REQUIRED, 'Sets the archive xml file for a local update.')
->addOption('xml', null, InputOption::VALUE_REQUIRED, 'Sets the archive xml file for a local update.')

Copy link

sonarcloud bot commented Nov 27, 2024

@AureRita AureRita self-assigned this Dec 2, 2024
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M0rgan01

Thank you for your PR, I tested it and it seems to works as you can see :

image

Tested from :
1.7.8.8 to 8.2
8.0.4 to 8.2
8.2 to 9.0.0
8.0.4 to 9.0.0

Because the PR seems to works as expected, It's QA ✔️

Thank you

@M0rgan01 M0rgan01 merged commit ef62f4b into PrestaShop:dev Dec 3, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants